Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preset select before segment #93

Merged
merged 3 commits into from
Sep 20, 2023
Merged

Preset select before segment #93

merged 3 commits into from
Sep 20, 2023

Conversation

chubetho
Copy link
Collaborator

Now user can select segmentation preset before process
Close #78

@chubetho chubetho requested review from 4lex0017 and twynb September 18, 2023 09:56
@chubetho chubetho self-assigned this Sep 18, 2023
@chubetho chubetho changed the title feat: preset Preset select before segment Sep 18, 2023
Copy link
Collaborator

@4lex0017 4lex0017 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add an alias for the presets so it isnt caps. also maybe add localization

@chubetho
Copy link
Collaborator Author

Please add an alias for the presets so it isnt caps. also maybe add localization

solved

src/frontend/composables/useConvertSecToMin.ts Outdated Show resolved Hide resolved
src/frontend/locales/de.json Outdated Show resolved Hide resolved
src/frontend/locales/de.json Outdated Show resolved Hide resolved
@chubetho chubetho requested review from twynb and 4lex0017 September 20, 2023 18:38
Copy link
Owner

@twynb twynb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chubetho chubetho merged commit db1b9b2 into main Sep 20, 2023
1 check passed
@chubetho chubetho deleted the segmentation_select branch September 21, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow setting segmentation parameters
3 participants